bugfix: use strict MariaDB detection in install advisor#273
Merged
TheWitness merged 1 commit intoCacti:developfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Syslog plugin’s install advisor to correctly detect MariaDB by using a strict stripos() comparison, and adds a small regression test plus changelog entry to prevent reintroducing the issue (Fixes #270).
Changes:
- Switch MariaDB detection from loose to strict
stripos(...) === falsecomparison in the install advisor. - Add a regression test to ensure the strict comparison remains in
setup.php. - Update
CHANGELOG.mdwith the issue reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
setup.php |
Fixes MariaDB detection comparison used to gate Aria engine selection in the install advisor. |
tests/regression/issue270_mariadb_detection_strict_test.php |
Adds a regression check to prevent reintroduction of the loose comparison. |
CHANGELOG.md |
Documents the fix for issue #270. |
Contributor
Author
|
Fixed in e913ca3 -- now uses |
somethingwithproof
force-pushed
the
bug/mariadb-detection-strict
branch
2 times, most recently
from
0a110bf to
55e4c82
Compare
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Mar 10, 2026
Refs Cacti#273 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
bug/mariadb-detection-strict
branch
from
55e4c82 to
8108b21
Compare
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Mar 12, 2026
Refs Cacti#273 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
bug/mariadb-detection-strict
branch
from
8108b21 to
10663f9
Compare
Refs Cacti#273 Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
bug/mariadb-detection-strict
branch
from
10663f9 to
f3c52ab
Compare
TheWitness
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #270
Validation